Merged
Conversation
Replace old deprecated label by new label Signed-off-by: Soule BA <souleb@nvidia.com>
souleb
commented
Feb 11, 2026
| } | ||
|
|
||
| mac, err := p.networkHelper.GetPFRepMACAddress("pf0hpf") | ||
| mac, err := p.networkHelper.GetHostPFMACAddressDPU("0") |
Contributor
Author
There was a problem hiding this comment.
Needed because of feat: use sriovnet to get host PF MAC address for provisioner
souleb
commented
Feb 11, 2026
| github.com/onsi/ginkgo/v2 v2.23.4 | ||
| github.com/onsi/gomega v1.36.3 | ||
| github.com/vishvananda/netlink v1.3.0 | ||
| github.com/nvidia/doca-platform v0.0.0-20260211082925-d6b82493d0c3 |
Contributor
Author
There was a problem hiding this comment.
This is bad that we need DPF here, as it means we have to use public-main
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace old deprecated label by new label